Re: [gentoo-portage-dev] [PATCH] repoman: always add a newline if the message body is one line

[Zac Medico]

On 01/14/2017 08:58 AM, Mike Gilbert wrote:
> The second line in a git commit message is supposed to be blank.
>
> Before:
>   dev-libs/libfoo: fix another bug
>   Package-Manager: Portage-2.3.3, Repoman-2.3.1
>
> After:
>   dev-libs/libfoo: fix another bug
>
>   Package-Manager: Portage-2.3.3, Repoman-2.3.1
> ---
>  repoman/pym/repoman/actions.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/repoman/pym/repoman/actions.py b/repoman/pym/repoman/actions.py
> index 58b00d494..82c76b2fb 100644
> --- a/repoman/pym/repoman/actions.py
> +++ b/repoman/pym/repoman/actions.py
> @@ -128,8 +128,9 @@ class Actions(object):
>  					myupdates, mymanifests, myremoved, mychanged, myautoadd,
>  					mynew, commitmessage)
>
> -		lastline = commitmessage.splitlines()[-1]
> -		if not ':' in lastline:
> +		lines = commitmessage.splitlines()
> +		lastline = lines[-1]
> +		if len(lines) == 1 or not ':' in lastline:

Maybe a regular expression would be better, like this:

   if len(lines) == 1 or re.match(r'^\S+:\s', lastline) is None:


>  			commitmessage += '\n'
>
>  		commit_footer = self.get_commit_footer()
>


-- 
Thanks,
Zac