Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, Brian Dolbec <dolsen@g.o>
Subject: Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete
Date: Tue, 15 Mar 2016 19:42:59
Message-Id: 56E865BB.6040502@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [Patch] Repoman rewrite stage2 modularization conversion complete by Zac Medico
1 On 03/15/2016 12:38 PM, Zac Medico wrote:
2 > On 03/15/2016 12:04 PM, Brian Dolbec wrote:
3 >> On Mon, 14 Mar 2016 18:04:56 -0700
4 >> Zac Medico <zmedico@g.o> wrote:
5 >>
6 >>
7 >>>> The only consumer for that allvalid variable is the metadata
8 >>>> UnusedCheck class.
9 >>>>
10 >>>> So the allvalid variable is True until found False
11 >>>> by whichever checks along the way find it to be False. Like a fuse,
12 >>>> it's good until it's blown, then it can never be good again. I
13 >>>> don't think this particular variable justifies a special class that
14 >>>> more fully mimics a fuse. Impossible to reset it like a breaker.
15 >>>
16 >>> Yeah, let's do it. It's a great opportunity to add clarity to the
17 >>> code, and prevent future goofs.
18 >>>
19 >>
20 >> Done, it is now dynamic_data['validity_fuse'] which is a Fuse instance.
21 >
22 > Nice, thank you!
23 >
24 > We can also use Fuse for the 'can_force' boolean, right?
25 >
26
27 For 'changed' as well.
28 --
29 Thanks,
30 Zac