Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, "i.Dark_Templar" <darktemplar@×××××××××××××××××××××.net>
Subject: Re: [gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces
Date: Tue, 28 May 2019 01:52:21
Message-Id: 24e3d192-a51b-fde0-972f-50693f8a1bf4@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces by "i.Dark_Templar"
1 On 5/27/19 1:23 PM, i.Dark_Templar wrote:
2 > These records are never removed and just pollute
3 > /etc/mtab if that's a regular file.
4 > And if /etc/mtab isn't a regular file,
5 > then attempts to modify it are pointless.
6 > ---
7 > lib/portage/process.py | 2 +-
8 > 1 file changed, 1 insertion(+), 1 deletion(-)
9 >
10 > diff --git a/lib/portage/process.py b/lib/portage/process.py
11 > index 0dba55de3..dfbda75de 100644
12 > --- a/lib/portage/process.py
13 > +++ b/lib/portage/process.py
14 > @@ -617,7 +617,7 @@ def _exec(binary, mycommand, opt_name, fd_pipes,
15 > os._exit(1)
16 > # mount new /proc for our namespace
17 > s = subprocess.Popen(['mount',
18 > - '-t', 'proc', 'proc', '/proc'])
19 > + '-n', '-t', 'proc', 'proc', '/proc'])
20 > mount_ret = s.wait()
21 > if mount_ret != 0:
22 > writemsg("Unable to mount new /proc: %d\n" % (mount_ret,),
23 >
24
25 Thanks, merged:
26
27 https://gitweb.gentoo.org/proj/portage.git/commit/?id=ee2e8e8d65713760f85664bcb004e67aed8228d3
28 --
29 Thanks,
30 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature