Re: [gentoo-portage-dev] [PATCH v2] news.py: Check only for major version when parsing

[Zac Medico]

On 05/19/2016 03:12 AM, Alexander Berntsen wrote:
> Only check the major version of news items, as GLEP 42 specifies an
> upgrade path for them. Future revisions to news item formats may yield
> minor number increments. GLEP 42 further ensures that only
> forwards-compatible changes may incur, as incompatible changes demand a
> major version increment.
>
> Suggested-by:  Ulrich Müller      <ulm@g.o>
> Signed-off-by: Alexander Berntsen <bernalex@g.o>
> ---
>  pym/portage/news.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pym/portage/news.py b/pym/portage/news.py
> index 784ba70..ea1b947 100644
> --- a/pym/portage/news.py
> +++ b/pym/portage/news.py
> @@ -9,6 +9,7 @@ __all__ = ["NewsManager", "NewsItem", "DisplayRestriction",
>  	"DisplayInstalledRestriction",
>  	"count_unread_news", "display_news_notifications"]
>
> +import fnmatch
>  import io
>  import logging
>  import os as _os
> @@ -270,7 +271,8 @@ class NewsItem(object):
>  			# Optimization to ignore regex matchines on lines that
>  			# will never match
>  			format_match = _formatRE.match(line)
> -			if format_match is not None and format_match.group(1) != '1.0':
> +			if (format_match is not None and
> +					not fnmatch.fnmatch(format_match.group(1), '1.*')):
>  				invalids.append((i + 1, line.rstrip('\n')))
>  				break
>  			if not line.startswith('D'):
>

Looks good.
-- 
Thanks,
Zac