Re: [gentoo-portage-dev] New proposed modular sync system

[Sebastian Luther]

Am 31.01.2014 08:27, schrieb Brian Dolbec:
>
>>> 18. Modify emerge-webrsync cli to use the new webrsync module
>>
>> I'd just remove emerge-webrsync and ask the user to use emerge --sync
>> instead.
>>
>
> Some people are not able to use a normal rsync tree due to firewall
> issues and bandwith restrictions.
>
>

I didn't mean to remove the functionality provided by emerge-webrsync.
Since in point 17 you want to move the functionality into a module, the
user should be able to set sync-type=web-rsync in repos.conf and have
emerge --sync sync it.

>>> Next up for discussion is what additional functionality should a
>>> module supply?
>>>
>>> I think it should provide a list or dictionary of the repos.conf
>>> variables it needs or uses.  I also think that the module should
>>> provide a function for validating the conf variables meet some
>>> minimum standard/obvious error checking.
>>
>> Why should it provide that list at all, if it has a function to
>> validate its input? The calling code should just check sync-type,
>> select the appropriate module and pass everything to it.
>>
>>
>
> I am thinking more about an emaint module for checking repos.conf
> entries and help generation.  The sync module would provide the
> validation function and the info the emaint module would use to list
> variable requirements.  Yes, the plugin module should provide it's own
> man page, but maybe it doesn't or the user just wants a quick list of
> the variable requirements.
>
>
> emaint --list --variables syncs
>
>   rsync:
>     ...
>
>   git:
>     ...
>     gpg-sig-uri
>
>   squashfs:
>     sync-uri
>     gpg-sig-uri  optional, blah blah,...
>     ...
>
>
>
I guess I'm just not familiar enough with your approach to see all the
things you want to do with it.