Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH 2/3] Update the QA checks to new eqatag API
Date: Sun, 02 Nov 2014 19:18:36
Message-Id: 1414955900-32567-2-git-send-email-mgorny@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 1/3] Introduce eqatag to output proper machine-readable QA logs by "Michał Górny"
1 ---
2 bin/install-qa-check.d/05double-D | 8 ++++----
3 bin/install-qa-check.d/90world-writable | 4 +---
4 2 files changed, 5 insertions(+), 7 deletions(-)
5
6 diff --git a/bin/install-qa-check.d/05double-D b/bin/install-qa-check.d/05double-D
7 index 7d958f1..4b7737c 100644
8 --- a/bin/install-qa-check.d/05double-D
9 +++ b/bin/install-qa-check.d/05double-D
10 @@ -3,12 +3,12 @@
11 DD_check() {
12 if [[ -d ${D%/}${D} ]] ; then
13 eqawarn "QA Notice: files installed in \${D}/\${D}:"
14 - local -i INSTALLTOD=0
15 + local files=()
16 while read -r -d $'\0' i ; do
17 - __eqawarnlog double-d "/${i##${D%/}${D}}"
18 - ((INSTALLTOD++))
19 + files+=( "${i#${D%/}${D}}" )
20 done < <(find "${D%/}${D}" -print0)
21 - die "Aborting due to QA concerns: ${INSTALLTOD} files installed in ${D%/}${D}"
22 + eqatag -v double-D "${files[@]/#//}"
23 + die "Aborting due to QA concerns: ${#files[@]} files installed in ${D%/}${D}"
24 fi
25 }
26
27 diff --git a/bin/install-qa-check.d/90world-writable b/bin/install-qa-check.d/90world-writable
28 index 490aaee..2b435ac 100644
29 --- a/bin/install-qa-check.d/90world-writable
30 +++ b/bin/install-qa-check.d/90world-writable
31 @@ -12,9 +12,7 @@ world_writable_check() {
32 if [[ -n ${unsafe_files} ]] ; then
33 eqawarn "QA Security Notice: world writable file(s):"
34
35 - for x in $unsafe_files ; do
36 - __eqawarnlog world-writable "$x"
37 - done
38 + eqatag -v world-writable $unsafe_files
39
40 eqawarn "This may or may not be a security problem, most of the time it is one."
41 eqawarn "Please double check that $PF really needs a world writeable bit and file bugs accordingly."
42 --
43 2.1.3