Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] die: call set +x since tracing only produces useless noise here
Date: Fri, 17 Jul 2015 20:48:52
Message-Id: 20150717134844.3e65baac.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] die: call set +x since tracing only produces useless noise here by Zac Medico
1 On Fri, 17 Jul 2015 12:29:53 -0700
2 Zac Medico <zmedico@g.o> wrote:
3
4 > ---
5 > bin/isolated-functions.sh | 1 +
6 > 1 file changed, 1 insertion(+)
7 >
8 > diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
9 > index 003c01d..5766921 100644
10 > --- a/bin/isolated-functions.sh
11 > +++ b/bin/isolated-functions.sh
12 > @@ -121,6 +121,7 @@ __helpers_die() {
13 > }
14 >
15 > die() {
16 > + set +x # tracing only produces useless noise here
17 > local IFS=$' \t\n'
18 >
19 > if ___eapi_die_can_respect_nonfatal; then
20
21
22 Looks good
23 --
24 Brian Dolbec <dolsen>