Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] portage.util.configparser: Commonize portable config file reading routine
Date: Sun, 22 May 2016 18:04:57
Message-Id: 5741F4C3.5080803@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 2/2] portage.util.configparser: Commonize portable config file reading routine by "Michał Górny"
1 On 05/22/2016 01:41 AM, Michał Górny wrote:
2 > ---
3 > pym/portage/_sets/__init__.py | 29 ++-----------------
4 > pym/portage/repository/config.py | 38 ++-----------------------
5 > pym/portage/util/_desktop_entry.py | 20 ++-----------
6 > pym/portage/util/configparser.py | 57 +++++++++++++++++++++++++++++++++++++-
7 > 4 files changed, 64 insertions(+), 80 deletions(-)
8
9 These patches look good. Note that the _native_kwargs function is not
10 really needed anymore, because it was just a workaround for this issue
11 which only affected python 2.6.4 and earlier:
12
13 http://bugs.python.org/issue4978
14 --
15 Thanks,
16 Zac

Replies