Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH] Sort repoman check results in output
Date: Sun, 30 Mar 2014 11:55:17
Message-Id: 1396180505-13208-1-git-send-email-mgorny@gentoo.org
1 Currently, the check results are output in dict order which is
2 implementation-defined. This makes it hard to compare results coming
3 from two machines (Python versions).
4
5 Instead, sort all the results lexically.
6 ---
7 pym/repoman/utilities.py | 2 +-
8 1 file changed, 1 insertion(+), 1 deletion(-)
9
10 diff --git a/pym/repoman/utilities.py b/pym/repoman/utilities.py
11 index aec61fe..415825e 100644
12 --- a/pym/repoman/utilities.py
13 +++ b/pym/repoman/utilities.py
14 @@ -309,7 +309,7 @@ def format_qa_output(formatter, stats, fails, dofull, dofail, options, qawarning
15 full = options.mode == 'full'
16 # we only want key value pairs where value > 0
17 for category, number in \
18 - filter(lambda myitem: myitem[1] > 0, iter(stats.items())):
19 + filter(lambda myitem: myitem[1] > 0, sorted(stats.items())):
20 formatter.add_literal_data(" " + category.ljust(30))
21 if category in qawarnings:
22 formatter.push_style("WARN")
23 --
24 1.9.1

Replies

Subject Author
Re: [gentoo-portage-dev] [PATCH] Sort repoman check results in output Alexander Berntsen <bernalex@g.o>