Gentoo Archives: gentoo-portage-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] install-qa-check.d: issue warnings for 32bit ELFs not using LFS
Date: Sat, 30 May 2015 18:32:07
Message-Id: 20150530183159.GI2101@vapier
In Reply to: Re: [gentoo-portage-dev] [PATCH v2] install-qa-check.d: issue warnings for 32bit ELFs not using LFS by Zac Medico
1 On 30 May 2015 11:22, Zac Medico wrote:
2 > On 05/30/2015 07:36 AM, Mike Frysinger wrote:
3 > > On 26 May 2015 08:58, Zac Medico wrote:
4 > >> On 05/26/2015 07:24 AM, Mike Frysinger wrote:
5 > >>> + # Only check on 32-bit systems. Filtering by $ARCH here isn't perfect, but
6 > >>> + # it should be good enough for our needs.
7 > >>> + case ${ARCH} in
8 > >>> + arm|mips|ppc|sh|x86) ;;
9 > >>> + *) return ;;
10 > >>> + esac
11 > >>
12 > >> Shouldn't we also enable this for 64-bit archs when multilib is enabled?
13 > >
14 > > yes, but i think we should start here first. getting multilib right is kind of
15 > > a pain. this should give us enough coverage i think to get people to start
16 > > filing bugs which implicitly covers multilib users. once the dust has settled,
17 > > we can look at expanding the multilib coverage. although that would really
18 > > require a python implementation, and the current install hooks logic implicitly
19 > > requires every file to be bash.
20 > >
21 > > to use your pkg-config example, it installs 32bit & 64bit ELFs into /usr/bin.
22 > > we can't scan all 32bit ELFs because it would incorrectly flag ILP32 ABIs like
23 > > x32 & n32.
24 >
25 > Our compute_multilib_category function has logic that could be used to
26 > separate and filter them:
27 >
28 > https://gitweb.gentoo.org/proj/portage.git/tree/pym/portage/dep/soname/multilib_category.py
29
30 that'd require a python implementation which hooks are somewhat limited by
31 currently ;)
32 -mik

Attachments

File name MIME type
signature.asc application/pgp-signature