Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, Sergei Trofimovich <slyfox@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: add --include-profiles=PROFILES
Date: Wed, 20 Nov 2019 10:25:58
Message-Id: 94455f99-e6b8-aa6f-6c87-7ec061a555e1@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] repoman: add --include-profiles=PROFILES by Sergei Trofimovich
1 On 11/18/19 4:21 PM, Sergei Trofimovich wrote:
2 > diff --git a/repoman/lib/repoman/modules/scan/depend/profile.py b/repoman/lib/repoman/modules/scan/depend/profile.py
3 > index d980f4eca..0b1d74483 100644
4 > --- a/repoman/lib/repoman/modules/scan/depend/profile.py
5 > +++ b/repoman/lib/repoman/modules/scan/depend/profile.py
6 > @@ -33,6 +33,7 @@ class ProfileDependsChecks(ScanBase):
7 > @param options: cli options
8 > @param repo_settings: repository settings instance
9 > @param include_arches: set
10 > + @param include_profiles: set
11 > @param caches: dictionary of our caches
12 > @param repoman_incrementals: tuple
13 > @param env: the environment
14 > @@ -46,6 +47,7 @@ class ProfileDependsChecks(ScanBase):
15 > self.options = kwargs.get('options')
16 > self.repo_settings = kwargs.get('repo_settings')
17 > self.include_arches = kwargs.get('include_arches')
18 > + self.include_profiles = kwargs.get('include_profiles')
19 > self.caches = kwargs.get('caches')
20 > self.repoman_incrementals = kwargs.get('repoman_incrementals')
21 > self.env = kwargs.get('env')
22 > @@ -81,8 +83,11 @@ class ProfileDependsChecks(ScanBase):
23 > if arch not in self.include_arches:
24 > continue
25 >
26 > - relevant_profiles.extend(
27 > - (keyword, groups, prof) for prof in self.profiles[arch])
28 > + for prof in self.profiles[arch]:
29 > + if self.include_profiles is not None:
30 > + if prof not in self.include_profiles:
31
32 Since prof is an instance of repoman.profile.ProfileDesc, you actually
33 have to use prof.sub_path for this containment check. That means your
34 benchmark skipped the profile that you intended to include.
35
36 > + continue
37 > + relevant_profiles.append((keyword, groups, prof))
38 --
39 Thanks,
40 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature