Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] EbuildBuild: call _record_binpkg_info earlier (bug 578204)
Date: Tue, 29 Mar 2016 10:21:27
Message-Id: 56FA571C.2040606@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH v2] EbuildBuild: call _record_binpkg_info earlier (bug 578204) by Zac Medico
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 27/03/16 01:13, Zac Medico wrote:
5 > + class _RecordBinpkgInfo(AsynchronousTask):
6 > +
7 > + __slots__ = ('ebuild_binpkg', 'ebuild_build',)
8 > +
9 > + def _start(self):
10 > + self.ebuild_build._record_binpkg_info(self.ebuild_binpkg)
11 > + AsynchronousTask._start(self)
12 > +
13 Maybe docstrings are warranted? Looks OK otherwise.
14
15 - --
16 Alexander
17 bernalex@g.o
18 https://secure.plaimi.net/~alexander
19 -----BEGIN PGP SIGNATURE-----
20 Version: GnuPG v2
21
22 iQIcBAEBCgAGBQJW+lcbAAoJENQqWdRUGk8BBpIP/1DiTHK8ujnK01yOKvpp+VfU
23 d/WCNQ7KC/QfQvbZ/jvDybvJE+o5pEOP37+hNY61lGle2kiTrSv7JBtM7Az2VohG
24 agU/4HSFp3TnyyuaQqWrb45qWlCjkIyf8OJNr8wVzmLH6L2BXwhTIiPSt41ix+SL
25 2JNqtB82dh4Uq/6Bzc8C8GwPZm0XbqWc2rhS2K6JBWaJhOTDfW/HhldBHO1z6sMJ
26 H/XgvWAZAfjhsdYGQhrYKHo+kdi8V4Je+/GFPsd/v0nPvEP6ZmW3KtAdBCbJPnIQ
27 xOLgMp3pOWzNoP9ILn95XDydoSWNyPkUJ4VLxK+MTkwEoNJ4pJH7bz6XBWgtrzrF
28 cXxDCTYrl2qnQq4GpwqMlJwIloYxT2px9EYoYUQPk/b+iktIazWesOcJypiS8m/S
29 SUL6zLqjQ93+FqF4jfKni0z6j9x1WzsEFJVVetScrPUOmz4ZpUXY6w/kEjF6KrHs
30 7vU8ujev7nO1HZMKYGjG67l4l3oRUtwRK8dZNfnjBum0IaCZKpESCnO8d4IP7TUN
31 Kkm4//UCZZ5K75WvycHv5cz2eb7qToeN7hGu/P2Swm4La04mnyv+0MDrY3Cm9xol
32 M4eCBKvUiDO+xjKMoeM+sSd4eMSncPr4E3F87L6RFpgf6Z9J64OUGCaktCShvZFm
33 f03DozRC/JUG0WfxqRpo
34 =9je0
35 -----END PGP SIGNATURE-----