| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
On 20/03/16 15:33, Adam Mills wrote: |
| 5 |
> + for set_name in root_config.sets: |
| 6 |
> + if set_name == "system": |
| 7 |
> + system = root_config.sets[set_name].findAtomForPackage( |
| 8 |
> + pkg, modified_use=self.conf.pkg_use_enabled(pkg)) |
| 9 |
> + elif set_name == "selected": |
| 10 |
> + world = root_config.sets[set_name].findAtomForPackage( |
| 11 |
> + pkg, modified_use=self.conf.pkg_use_enabled(pkg)) |
| 12 |
> + elif user_set is None and root_config.sets[set_name].isUserSet(): |
| 13 |
> + user_set = root_config.sets[set_name].findAtomForPackage( |
| 14 |
> + pkg, modified_use=self.conf.pkg_use_enabled(pkg)) |
| 15 |
This is really silly. At the very least try to not repeat yourself so |
| 16 |
much. |
| 17 |
|
| 18 |
The patch otherwise looks OK, and the idea is OK by me. Unless someone |
| 19 |
has any big objections, I can probably merge a cleaned up patch. |
| 20 |
- -- |
| 21 |
Alexander |
| 22 |
bernalex@g.o |
| 23 |
https://secure.plaimi.net/~alexander |
| 24 |
-----BEGIN PGP SIGNATURE----- |
| 25 |
Version: GnuPG v2 |
| 26 |
|
| 27 |
iQIcBAEBCgAGBQJW+j5tAAoJENQqWdRUGk8BKpYP/iG5tLtEv7Zf7AbPOj4Dkt1V |
| 28 |
t25DMqUU0+uq3Wu0AsUsGYxg8K4dFMZ3+t54w4aykF5/lGNz/cz+O1NFy7WgQ/Y4 |
| 29 |
9pxkPIQ8py9FX8uh4Hm5/fplBJ5RP1CvvftLeImpKx/B2GTqtLDx0EYehfqRqWNa |
| 30 |
2Hx6TE1GH3bbvQgJpl65L4c30JfIBP4pcW95EzUc4XFE87KV0abFFsPLc8sEewp8 |
| 31 |
NXDDvLZnC+8+BKlLuhyZArxfDp02kQWLd7ho3Uq1rB1LVTUCbxLkV8F9UHtCX9/w |
| 32 |
XyyGkg/Xe4Ev1oLcMuEGWGcoQDdLA03CrTzZ59TYIrP2+/0EBCXfNPSy9SLehIew |
| 33 |
N+RpgRqc6ecRVq4Nm5NbHfcYmieSKIJD9KPlLqFOShdLEn92gZp2syKkKd+R5JwE |
| 34 |
voKVGMgAiJinZkNtwp/j4wgCoLf++I4FJ4BOWAkc7gkKOaDT7UnK2q3M9n6DTNtP |
| 35 |
kbyB0cRMSbyMN75vLi2LdB37xC7a2aWCNUi0ssL183bocxhtcRUCxpUsA+dRnGWP |
| 36 |
dKCoMzoYVcEARxbzukoJ1vuF+GN+tMoIHfAaXiAhTkwENn+s64b3pYy7tDRBjLxt |
| 37 |
Wi3Fvh9h2ipU42wc0p8puZmT9v+60rcUKbNCjLQD9lEX9nh6bR91gB7FlPzU/ss8 |
| 38 |
Kqz55vBVouA/Fwkn+qZi |
| 39 |
=TBB6 |
| 40 |
-----END PGP SIGNATURE----- |
Archives