Gentoo Archives: gentoo-portage-dev

From: Alec Warner <antarus@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Wolfgang E. Sanyer" <WolfgangESanyer@×××××.com>, Matt Turner <mattst88@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH 2/4] portage.eapi: use tuple instead of str for namedtuple definition
Date: Wed, 09 Mar 2022 01:12:22
Message-Id: CAAr7Pr8201EVzU=YB7FdmTk7CeJpdo6u-YVS1DgpWD8eV9hU0Q@mail.gmail.com
In Reply to: [gentoo-portage-dev] [PATCH 2/4] portage.eapi: use tuple instead of str for namedtuple definition by Matt Turner
1 Looks merge-able.
2
3 On Wed, Feb 23, 2022 at 8:15 PM Matt Turner <mattst88@g.o> wrote:
4 >
5 > From: "Wolfgang E. Sanyer" <WolfgangESanyer@×××××.com>
6 >
7 > Reviewed-by: Matt Turner <mattst88@g.o>
8 > Signed-off-by: Wolfgang E. Sanyer <WolfgangESanyer@×××××.com>
9 > ---
10 > lib/portage/eapi.py | 52 ++++++++++++++++++++++++++++-----------------
11 > 1 file changed, 33 insertions(+), 19 deletions(-)
12 >
13 > diff --git a/lib/portage/eapi.py b/lib/portage/eapi.py
14 > index adee87d00..18069b04b 100644
15 > --- a/lib/portage/eapi.py
16 > +++ b/lib/portage/eapi.py
17 > @@ -288,25 +288,39 @@ def eapi_has_sysroot(eapi):
18 >
19 > _eapi_attrs = collections.namedtuple(
20 > "_eapi_attrs",
21 > - "allows_package_provided "
22 > - "bdepend "
23 > - "broot "
24 > - "dots_in_PN dots_in_use_flags "
25 > - "exports_AA "
26 > - "exports_EBUILD_PHASE_FUNC "
27 > - "exports_ECLASSDIR "
28 > - "exports_KV "
29 > - "exports_merge_type "
30 > - "exports_PORTDIR "
31 > - "exports_replace_vars "
32 > - "feature_flag_test "
33 > - "idepend iuse_defaults iuse_effective posixish_locale "
34 > - "path_variables_end_with_trailing_slash "
35 > - "prefix "
36 > - "repo_deps required_use required_use_at_most_one_of "
37 > - "selective_src_uri_restriction slot_operator slot_deps "
38 > - "src_uri_arrows strong_blocks use_deps use_dep_defaults "
39 > - "empty_groups_always_true sysroot",
40 > + (
41 > + "allows_package_provided",
42 > + "bdepend",
43 > + "broot",
44 > + "dots_in_PN",
45 > + "dots_in_use_flags",
46 > + "exports_AA",
47 > + "exports_EBUILD_PHASE_FUNC",
48 > + "exports_ECLASSDIR",
49 > + "exports_KV",
50 > + "exports_merge_type",
51 > + "exports_PORTDIR",
52 > + "exports_replace_vars",
53 > + "feature_flag_test",
54 > + "idepend",
55 > + "iuse_defaults",
56 > + "iuse_effective",
57 > + "posixish_locale",
58 > + "path_variables_end_with_trailing_slash",
59 > + "prefix",
60 > + "repo_deps",
61 > + "required_use",
62 > + "required_use_at_most_one_of",
63 > + "selective_src_uri_restriction",
64 > + "slot_operator",
65 > + "slot_deps",
66 > + "src_uri_arrows",
67 > + "strong_blocks",
68 > + "use_deps",
69 > + "use_dep_defaults",
70 > + "empty_groups_always_true",
71 > + "sysroot",
72 > + ),
73 > )
74 >
75 >
76 > --
77 > 2.34.1
78 >
79 >