Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] [PATCH v2] repoman: fix dependency.unknown to ignore USE deps (bug 525376)
Date: Thu, 02 Apr 2015 23:46:13
Message-Id: 1428018353-14353-1-git-send-email-zmedico@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] repoman: fix dependency.unknown to ignore USE deps (bug 545294) by Zac Medico
1 The surrounding code is ignorant of USE flags, because it calls
2 use_reduce(matchall=True), therefore it makes sense for the
3 dependency.unknown code to ignore USE deps.
4
5 X-Gentoo-Bug: 525376
6 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=525376
7 ---
8 [PATCH v2] only changes the bug references from bug 545294 to bug 525376
9
10 bin/repoman | 5 +++--
11 1 file changed, 3 insertions(+), 2 deletions(-)
12
13 diff --git a/bin/repoman b/bin/repoman
14 index 7101a00..4a21e37 100755
15 --- a/bin/repoman
16 +++ b/bin/repoman
17 @@ -2049,9 +2049,10 @@ for x in effective_scanlist:
18
19 # Skip dependency.unknown for blockers, so that we
20 # don't encourage people to remove necessary blockers,
21 - # as discussed in bug #382407.
22 + # as discussed in bug 382407. We use atom.without_use
23 + # due to bug 525376.
24 if not is_blocker and \
25 - not portdb.xmatch("match-all", atom) and \
26 + not portdb.xmatch("match-all", atom.without_use) and \
27 not atom.cp.startswith("virtual/"):
28 unknown_pkgs.add((mytype, atom.unevaluated_atom))
29
30 --
31 2.3.1

Replies