Re: [gentoo-portage-dev] [PATCH] install-qa-check.d/90world-writable: fix usage of missing function

[Brian Dolbec]

Subject: install-qa-check.d/90world-writable: fix usage of missing function

Perhaps something like...                     Fix missed eqatag() call
                    or...                     Fix missed __eqawarnlog() removal



On Sat, 22 Nov 2014 03:50:40 +1100
Michael Palimaka <kensington@g.o> wrote:

> Fixes: 6dafdc288976 ("Remove __eqalog & __eqawarnlog")

Please put more detail than just a partial hash.


eg:

Fixes: 6dafdc28897682f7b8c77b7863b5713634974647
Subject: Remove __eqalog & __eqawarnlog
Author: Michał Górny <mgorny@g.o> (Sun 02 Nov 2014 11:16:04 AM PST)

---
The above gives enough information to track the commit even if the hash has changed.


> ---
>  bin/install-qa-check.d/90world-writable | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/bin/install-qa-check.d/90world-writable
> b/bin/install-qa-check.d/90world-writable index 2b435ac..1fb2a8f
> 100644 --- a/bin/install-qa-check.d/90world-writable
> +++ b/bin/install-qa-check.d/90world-writable
> @@ -23,9 +23,8 @@ world_writable_check() {
>  	if [[ -n ${unsafe_files} ]] ; then
>  		eqawarn "QA Notice: Unsafe files detected (set*id
> and world writable)"
> -		for x in $unsafe_files ; do
> -			__eqawarnlog world-writable-setid "$x"
> -		done
> +		eqatag -v world-writable-setid $unsafe_files
> +
>  		die "Unsafe files found in \${D}.  Portage will not
> install them." fi
>



-- 
Brian Dolbec <dolsen>