Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 1/1] Add a test case for PMS-compliant usage of the ROOT variable.
Date: Wed, 11 May 2016 16:34:29
Message-Id: 20160511093335.27224ce6.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 1/1] Add a test case for PMS-compliant usage of the ROOT variable. by Mike Gilbert
1 On Wed, 11 May 2016 12:27:10 -0400
2 Mike Gilbert <floppym@g.o> wrote:
3
4 > On Wed, May 11, 2016 at 12:08 PM, Michael Orlitzky <mjo@g.o>
5 > wrote:
6 > > A recent thread on gentoo-dev proposed a change to the devmanual's
7 > > description of the ROOT variable:
8 > >
9 > > https://archives.gentoo.org/gentoo-dev/message/8901669dd375ca0fdb610efef0ddfe6f
10 > >
11 > > The proposed change would bring the devmanual's language in line
12 > > with the PMS. That discussion reveals that the use of ROOT outside
13 > > of pkg_* is illegal, yet current versions of repoman/portage allow
14 > > it. This commit adds a test ebuild that violates the PMS (with
15 > > respect to ROOT) in several ways.
16 >
17 > This looks good to me, very thorough. I say go ahead and push it.
18 >
19
20 I agree, and thank you.
21
22 I'll work on adding this check to repoman after I finish getting some
23 in progress changes done so the new repoman code can be released.
24
25 --
26 Brian Dolbec <dolsen>

Replies