Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed
Date: Tue, 07 Jul 2015 18:13:23
Message-Id: 20150707111314.788749b8.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] unpack: avoid useless chmods to improve speed by Michael Haubenwallner
1 On Tue, 7 Jul 2015 14:12:33 +0200
2 Michael Haubenwallner <haubi@g.o> wrote:
3
4 > X-Gentoo-Bug: 554084
5 > X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=554084
6 > ---
7 > bin/phase-helpers.sh | 4 ++--
8 > 1 file changed, 2 insertions(+), 2 deletions(-)
9 >
10 > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
11 > index efd2cfa..b446060 100644
12 > --- a/bin/phase-helpers.sh
13 > +++ b/bin/phase-helpers.sh
14 > @@ -531,8 +531,8 @@ unpack() {
15 > done
16 > # Do not chmod '.' since it's probably ${WORKDIR} and
17 > PORTAGE_WORKDIR_MODE # should be preserved.
18 > - find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
19 > - ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
20 > + find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
21 > + -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
22 > }
23 >
24 > econf() {
25
26 Merged, Thanks
27
28 --
29 Brian Dolbec <dolsen>