Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] repoman: check for ebuilds not using slot operator against multi-slot packages.
Date: Mon, 04 Aug 2014 21:56:14
Message-Id: 20140804235638.62b76a3b@pomiot.lan
In Reply to: [gentoo-portage-dev] [PATCH v2] repoman: check for ebuilds not using slot operator against multi-slot packages. by "Michał Górny"
1 Dnia 2014-08-04, o godz. 23:15:59
2 Michał Górny <mgorny@g.o> napisał(a):
3
4 > The idea if that a particular dependency atom matches more than one slot
5 > of a package, you are supposed to either use := or :* operator
6 > (or a specific :slot dependency), whichever is appropriate.
7 >
8 > This will help catching mistakes (when packages become slotted) and make
9 > cross-slot behavior clear (it is undefined with no slot operator). I
10 > will estimate the amount of new warnings later.
11
12 So, I don't know if this patch affects repoman speed really. It reuses
13 the result of xmatch() that is done for 'dependency.unknown' but calls
14 aux_get() to obtain SLOT additionally.
15
16 As for the result, it gives 3941 new repoman warnings. Most of them are
17 packages that had compatibility slots introduced without updating
18 rev-deps, e.g.:
19
20 app-admin/apache-tools/apache-tools-2.4.10.ebuild: RDEPEND: 'dev-libs/openssl'
21 app-admin/augeas/augeas-0.10.0-r1.ebuild: RDEPEND: 'sys-libs/readline'
22 app-admin/logstalgia/logstalgia-1.0.3-r1.ebuild: RDEPEND: 'virtual/jpeg'
23
24 Some of them clearly ask for missing :=
25
26 app-arch/rpm/rpm-4.11.2.ebuild: RDEPEND: '>=sys-libs/db-4.5'
27
28 and some likely for eclass or some kind of :*
29
30 app-accessibility/brltty/brltty-5.0-r3.ebuild: RDEPEND: '>=virtual/jre-1.4'
31 app-text/docbook-xsl-stylesheets/docbook-xsl-stylesheets-1.78.0.ebuild: RDEPEND: 'dev-lang/ruby'
32
33 (of course, the check works only for EAPI=5 packages)
34
35 --
36 Best regards,
37 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature