| 1 |
On 01/29/2015 11:45 AM, Brian Dolbec wrote: |
| 2 |
> From mgorny's suggestion, rename _sync() to update(). |
| 3 |
> Raise NotImplementedError in base classes. |
| 4 |
> Directly override sync() in websync module. |
| 5 |
> Fix up line spacing to be consistent. |
| 6 |
> --- |
| 7 |
> pym/portage/sync/modules/cvs/cvs.py | 10 +++--- |
| 8 |
> pym/portage/sync/modules/git/git.py | 8 ++--- |
| 9 |
> pym/portage/sync/modules/rsync/rsync.py | 12 +++---- |
| 10 |
> pym/portage/sync/modules/svn/svn.py | 10 +++--- |
| 11 |
> pym/portage/sync/modules/websync/websync.py | 21 +++++------ |
| 12 |
> pym/portage/sync/syncbase.py | 56 ++++++++++++++++++----------- |
| 13 |
> 6 files changed, 64 insertions(+), 53 deletions(-) |
| 14 |
|
| 15 |
Looks good, but it feels a little bit crazy to split out a NewBase class |
| 16 |
when WebRsync is the only one that doesn't inherit from it. WebRsync is |
| 17 |
a very special case, and it could just as well inherit from NewBase, |
| 18 |
with the new() method calling update(). |
| 19 |
-- |
| 20 |
Thanks, |
| 21 |
Zac |
Archives