Re: [gentoo-portage-dev] [PATCHES] Random issues and refactoring before EAPI6 series

[Michał Górny]

Dnia 2014-08-18, o godz. 19:51:35
Michał Górny <mgorny@g.o> napisał(a):

> dol-sen asked me to send all of them in a serie. Those are minor
> bugfixes and code refactoring done to prepare for EAPI6 code.
>
> 1 & 2 cleans up econf. In EAPI6 we will likely be adding --docdir
> and --htmldir there, so we should add it in nice code rather than
> copying the bad one.
>
> 3-4 aim to clean up EAPI handling a bit. It's far from perfect, but 3 at
> least fixes the bug that EAPI 5 is considered unsupported. Further
> changes can be done in the future.
>
> 5 fixes PMS incompatibility that causes 'nonfatal' to prevent 'die' from
> working correctly. I'm pretty sure the bug was mentioned by PMS team
> already but nobody considered it important enough to report a bug. EAPI
> 6 'nonfatal die' support will land in place of that conditional.
>
> 6 aims to simplify the phase setting function that is hard to understand
> and the moment, and has a few unnecessary, hard-to-understand side
> effects like declaring non-existent __eapi2_src_*() phases. The new code
> is much cleaner and makes adding new phases in future EAPIs trivial. It
> also prevents from calling default_* function for another phase as
> forbidden by PMS.

1-4 & 6 committed.

5 needs a second look since it seems that not all functions use
__helper_die correctly. While at it, __eapi0_src_test should use emake,
and it has comment about nonfatal emake being too verbose -- we should
investigate that too. It doesn't make sense for nonfatal logic to
output warnings.

-- 
Best regards,
Michał Górny