| 1 |
On Monday 13 January 2014 19:08:30 creffett@g.o wrote: |
| 2 |
> From: Chris Reffett <creffett@g.o> |
| 3 |
|
| 4 |
you might want to set ~/.gitconfig to have your name/email so that git |
| 5 |
sendemail uses the right info in the actual e-mail From: field |
| 6 |
|
| 7 |
> + undefined_phases_re = |
| 8 |
> re.compile(r'^\s*(src_configure|src_prepare)\s*\(\)') |
| 9 |
|
| 10 |
you use re.match, so technically the ^ is redundant |
| 11 |
|
| 12 |
i'd suggest merging the regex a little: |
| 13 |
r'^\ssrc_(configure|prepare)\s*\(\)' |
| 14 |
|
| 15 |
could check for pkg_pretend/pkg_info too (it's new to EAPI 4) |
| 16 |
|
| 17 |
the regex is naive and can match valid ebuilds. consider ones that handle |
| 18 |
$EAPI itself and will call the right funcs as necessary. can you check the |
| 19 |
tree to see if anyone is doing this ? if so, we should drop a note to the dev |
| 20 |
list and get them fixed up. |
| 21 |
-mike |
Archives