| 1 |
On Sun, 19 Jan 2014 18:01:23 -0800 |
| 2 |
"W. Trevor King" <wking@×××××××.us> wrote: |
| 3 |
|
| 4 |
> On Mon, Jan 20, 2014 at 02:41:41AM +0100, Tom Wijsman wrote: |
| 5 |
> > There is some duplicate code here, I think the conditions can be |
| 6 |
> > rewritten in such way that the duplicate code doesn't take place. |
| 7 |
> |
| 8 |
> Do you want a rewrite squashed into this commit, or as a follow-on |
| 9 |
> commit after this one (which gets a test suite in v3)? |
| 10 |
|
| 11 |
Sound more sane to do in a follow-up commit. |
| 12 |
|
| 13 |
While writing this review I didn't note that you were just moving most |
| 14 |
code, now you have ideas for further refactoring I guess. :) |
| 15 |
|
| 16 |
-- |
| 17 |
With kind regards, |
| 18 |
|
| 19 |
Tom Wijsman (TomWij) |
| 20 |
Gentoo Developer |
| 21 |
|
| 22 |
E-mail address : TomWij@g.o |
| 23 |
GPG Public Key : 6D34E57D |
| 24 |
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D |
Archives