Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Cc: ulm@g.o
Subject: [gentoo-portage-dev] [PATCH] news.py: Check only for major version when parsing
Date: Wed, 18 May 2016 08:38:06
Message-Id: 1463560612-16330-1-git-send-email-bernalex@gentoo.org
1 Only check the major version of news items, as GLEP 42 specifies an
2 upgrade path for them. Future revisions to news item formats may yield
3 minor number increments. GLEP 42 further ensures that only
4 forwards-compatible changes may incur, as incompatible changes demand a
5 major version increment.
6
7 Suggested-by: Ulrich Müller <ulm@g.o>
8 Signed-off-by: Alexander Berntsen <bernalex@g.o>
9 ---
10 pym/portage/news.py | 2 +-
11 1 file changed, 1 insertion(+), 1 deletion(-)
12
13 diff --git a/pym/portage/news.py b/pym/portage/news.py
14 index 784ba70..f52d96e 100644
15 --- a/pym/portage/news.py
16 +++ b/pym/portage/news.py
17 @@ -270,7 +270,7 @@ class NewsItem(object):
18 # Optimization to ignore regex matchines on lines that
19 # will never match
20 format_match = _formatRE.match(line)
21 - if format_match is not None and format_match.group(1) != '1.0':
22 + if format_match is not None and format_match.group(1) != '1.*':
23 invalids.append((i + 1, line.rstrip('\n')))
24 break
25 if not line.startswith('D'):
26 --
27 2.7.3

Replies