Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare()
Date: Wed, 18 Nov 2015 07:12:09
Message-Id: 564C24C0.5040708@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] EAPI 6: Fail if eapply_user is not called in src_prepare() by Ulrich Mueller
1 On 11/17/2015 11:01 PM, Ulrich Mueller wrote:
2 >>>>>> On Tue, 17 Nov 2015, Michał Górny wrote:
3 >
4 >> __ebuild_phase src_prepare
5 >> +
6 >> + # keep path in eapply_user in sync!
7 >> + if [[ ! -f ${T}/.portage_user_patches_applied ]]; then
8 >> + die "eapply_user (or default) must be called in src_prepare()!"
9 >> + fi
10 >> +
11 >
12 > What happens if an ebuild calls eapply_user in src_unpack but not
13 > in src_prepare?
14
15 It will succeed in that case.
16
17 If necessary, we can make eapply_user die if it's called during the
18 wrong phase.
19
20 >
21 > Ulrich
22 >
23 --
24 Thanks,
25 Zac

Replies