Re: [gentoo-portage-dev] [PATCH] Add support for travis ci

[X dej]

First, this seems fishy:
"$(python -V 2>&1 | sed -e 's/Python //' -e 's/\.[^\.]*$//')"
'[^\.]' and '[^.\]' means the same: anything except dots and backslashes.
'[^.]' seems more reasonable.

Second, as this is an argument to sudo, I would prefer the more secure:
"$(python -V 2>&1 | grep -o '[1-9][0-9]*\.[0-9]*')"
which only let numbers, dots and spaces pass its filter (assuming that python
-V may contain garbage).

Xdej

2014-07-06 22:25 UTC+02:00, Manuel Rüger <mrueg@g.o>:
> Updated patch, I forgot to remove debug statement.
>
> Manuel
>
> On 07/06/2014 10:17 PM, Manuel Rüger wrote:
>> This patch adds support for travis continuous integration.
>>
>> Example output: https://travis-ci.org/mrueg/portage/builds/29268364
>>
>> Cheers
>>
>> Manuel
>>
>