| 1 |
> On 26 Jul 2022, at 00:33, Mike Gilbert <floppym@g.o> wrote: |
| 2 |
> |
| 3 |
> On Mon, Jul 25, 2022 at 11:38 AM Fabian Groffen <grobian@g.o> wrote: |
| 4 |
>> |
| 5 |
>> bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects |
| 6 |
>> |
| 7 |
>> Check for dylib on Darwin, so on everything else. |
| 8 |
>> |
| 9 |
>> Signed-off-by: Fabian Groffen <grobian@g.o> |
| 10 |
>> |
| 11 |
>> diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries |
| 12 |
>> index 8dc35bb87..a477ec9cb 100644 |
| 13 |
>> --- a/bin/install-qa-check.d/80libraries |
| 14 |
>> +++ b/bin/install-qa-check.d/80libraries |
| 15 |
>> @@ -140,7 +140,9 @@ lib_check() { |
| 16 |
>> local abort="no" |
| 17 |
>> local a s |
| 18 |
>> for a in "${ED%/}"/usr/lib*/*.a ; do |
| 19 |
>> - s=${a%.a}.so |
| 20 |
>> + [[ ${CHOST} == *-darwin* ]] \ |
| 21 |
>> + && s=${a%.a}.dylib \ |
| 22 |
>> + || s=${a%.a}.so |
| 23 |
> |
| 24 |
> I would find this much easier to read if you converted it to an |
| 25 |
> if/else statement instead of chaining && and ||. |
| 26 |
|
| 27 |
Yes, please. |
Archives