Gentoo Archives: gentoo-portage-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH v3 1/2] bin/install-qa-check.d: add new 90bad-bin-owner QA check.
Date: Tue, 07 Aug 2018 17:44:11
Message-Id: 6d072a67-8785-16a5-7068-13939f598233@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v3 1/2] bin/install-qa-check.d: add new 90bad-bin-owner QA check. by Zac Medico
1 On 08/07/2018 01:34 PM, Zac Medico wrote:
2 >
3 > Why not use ${ED%/} instead of ${D%/} here, so that the output is the
4 > same regardless of ${EPREFIX}?
5 >
6
7 We want to show where the executable was actually installed, and
8 generally that includes EPREFIX. For example, I'd want to see
9
10 /var/tmp/whatever/.../root/prefix/usr/bin/foo
11
12 reported as
13
14 /root/prefix/usr/bin/foo
15
16 rather than
17
18 /usr/bin/foo
19
20 Of course, these checks are now skipped on prefix systems anyway, so
21 it's a bit of a moot point. But I think it's more future-proof to strip
22 only the $D.

Replies