Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: Zac Medico <zmedico@g.o>
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] portage.util.configparser: Commonize portable config file reading routine
Date: Tue, 24 May 2016 06:29:04
Message-Id: 20160524082855.5f522521.mgorny@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 2/2] portage.util.configparser: Commonize portable config file reading routine by Zac Medico
1 On Sun, 22 May 2016 11:04:51 -0700
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On 05/22/2016 01:41 AM, Michał Górny wrote:
5 > > ---
6 > > pym/portage/_sets/__init__.py | 29 ++-----------------
7 > > pym/portage/repository/config.py | 38 ++-----------------------
8 > > pym/portage/util/_desktop_entry.py | 20 ++-----------
9 > > pym/portage/util/configparser.py | 57 +++++++++++++++++++++++++++++++++++++-
10 > > 4 files changed, 64 insertions(+), 80 deletions(-)
11 >
12 > These patches look good. Note that the _native_kwargs function is not
13 > really needed anymore, because it was just a workaround for this issue
14 > which only affected python 2.6.4 and earlier:
15 >
16 > http://bugs.python.org/issue4978
17
18 Pushed now, thanks.
19
20 I'll do a global _native_kwargs cleanup in a separate patch.
21
22 --
23 Best regards,
24 Michał Górny
25 <http://dev.gentoo.org/~mgorny/>