Re: [gentoo-portage-dev] [PATCH 5/6] Install Python modules using setup.py

[Brian Dolbec]

On Thu, 21 Aug 2014 22:19:43 +0200
Michał Górny <mgorny@g.o> wrote:

> ---
>  .gitignore           |   1 +
>  Makefile             | 215 --------------------
>  doc/Makefile         |  11 -
>  pym/portage/const.py |   4 +-
>  setup.py             | 557
> +++++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed,
> 560 insertions(+), 228 deletions(-) delete mode 100644 Makefile
>  delete mode 100644 doc/Makefile
>  create mode 100755 setup.py




> diff --git a/setup.py b/setup.py new file mode 100755
> index 0000000..bd6e506 --- /dev/null
> +++ b/setup.py
> @@ -0,0 +1,557 @@
> +#!/usr/bin/env python
> +#	vim:fileencoding=utf-8
> +# (c) 2010 Michał Górny <mgorny@g.o>
> +# Released under the terms of the 2-clause BSD license.
> +
> +from distutils.core import setup, Command
> +from distutils.command.build_scripts import build_scripts
> +from distutils.command.clean import clean
> +from distutils.command.install import install
> +from distutils.command.install_data import install_data
> +from distutils.command.install_lib import install_lib
> +from distutils.command.install_scripts import install_scripts
> +from distutils.dir_util import remove_tree
> +from distutils.util import change_root, subst_vars
> +
> +import codecs, collections, glob, os, os.path, re, subprocess, sys
> +
> +# TODO:
> +# - smarter rebuilds of docs w/ 'install_docbook' and
> 'install_epydoc'. +
> +package_name = 'portage'
> +package_version = '2.2.12'

Why hard code the version?  can you not import it?  or did you add this
to the sed list in mkrelease.sh?

-- 
Brian Dolbec <dolsen>