Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] chpathtool.py: avoid unnecessary optparse import
Date: Mon, 19 Jan 2015 15:34:05
Message-Id: 20150119073341.2c16af6b.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] chpathtool.py: avoid unnecessary optparse import by Zac Medico
1 On Mon, 19 Jan 2015 01:13:17 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > Since commit d217db2bc76e4c1a2e75685b4a00e25f7d8142a8, the optparse
5 > module has been imported unconditionally, even when the argparse
6 > module is available. Fix it to import optparse only if the argparse
7 > import fails.
8 >
9 > Fixes: d217db2bc76e ("Make use of optparse to fix argument parsing
10 > for Python 2.6 in bin/chpathtool.py.") ---
11 > bin/chpathtool.py | 22 ++++++++--------------
12 > 1 file changed, 8 insertions(+), 14 deletions(-)
13 >
14 >
15
16 Looks good. :)
17
18 --
19 Brian Dolbec <dolsen>