Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Cc: | "Michał Górny" <mgorny@g.o> | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX | ||
| Date: | Wed, 19 Apr 2017 16:21:27 | ||
| Message-Id: | 22775.36479.578993.520088@a1i15.kph.uni-mainz.de | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX by Ulrich Mueller |
||
| 1 | >>>>> On Wed, 19 Apr 2017, Ulrich Mueller wrote: |
| 2 | |
| 3 | >> +if [[ ${target:0:1} == "/" && ${target} != "${EPREFIX}"* ]]; then |
| 4 | |
| 5 | > I think you want an additional slash in the second condition, in order |
| 6 | > to prevent /foo/barbaz from matching if EPREFIX is equal to /foo/bar: |
| 7 | |
| 8 | > if [[ ${target:0:1} == "/" && ${target}/ != "${EPREFIX}"/* ]]; then |
| 9 | |
| 10 | >> + target="${EPREFIX}${target}" |
| 11 | |
| 12 | One more point, maybe output a QA warning here? |
| 13 | |
| 14 | >> +fi |
| 15 | >> ln -snf "${target}" "${ED}${2}" |
| 16 | >> |
| 17 | >> ret=$? |
| 18 | |
| 19 | Ulrich |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH] dosym: protect Prefix hack from double EPREFIX | "Michał Górny" <mgorny@g.o> |