Gentoo Archives: gentoo-portage-dev

From: Ryan Hill <dirtyepic@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] Re: [PATCH] econf: update configure/config.{sub,guess} atomically to avoid races
Date: Sat, 21 Dec 2013 02:58:00
Message-Id: 20131220210717.143e9f02@caribou.gateway.pace.com
In Reply to: [gentoo-portage-dev] [PATCH] econf: update configure/config.{sub,guess} atomically to avoid races by Mike Frysinger
1 On Tue, 17 Dec 2013 18:28:12 -0500
2 Mike Frysinger <vapier@g.o> wrote:
3
4 > Use $BASHPID which will be unique even in subshells.
5 >
6 > URL: https://bugs.gentoo.org/487478
7 > ---
8 > bin/phase-helpers.sh | 17 +++++++++++------
9 > 1 file changed, 11 insertions(+), 6 deletions(-)
10 >
11 > diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
12 > index ec48c94..1a7ae03 100644
13 > --- a/bin/phase-helpers.sh
14 > +++ b/bin/phase-helpers.sh
15 > @@ -469,6 +469,7 @@ unpack() {
16 >
17 > econf() {
18 > local x
19 > + local pid=${BASHPID}
20
21 This requires bash 4.0. I'm all for it, but haters gonna hate.
22
23
24 --
25 Ryan Hill psn: dirtyepic_sk
26 gcc-porting/toolchain/wxwidgets @ gentoo.org
27
28 47C3 6D62 4864 0E49 8E9E 7F92 ED38 BD49 957A 8463

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies