Re: [gentoo-portage-dev] [PATCH] emerge: Don't die when the user has an invalid locale setting

[Mike Gilbert]

On Tue, Aug 5, 2014 at 3:23 PM, Alec Warner <antarus@g.o> wrote:
> On Mon, Aug 4, 2014 at 12:45 PM, Mike Gilbert <floppym@g.o> wrote:
>>
>> ---
>>  pym/_emerge/main.py | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/pym/_emerge/main.py b/pym/_emerge/main.py
>> index 1a920f7..722da84 100644
>> --- a/pym/_emerge/main.py
>> +++ b/pym/_emerge/main.py
>> @@ -999,7 +999,10 @@ def emerge_main(args=None):
>>         args = portage._decode_argv(args)
>>
>>         # Use system locale.
>> -       locale.setlocale(locale.LC_ALL, '')
>> +       try:
>> +               locale.setlocale(locale.LC_ALL, '')
>> +       except locale.Error as e:
>> +               print(e)
>
>
> Portage has its own output functions (writemsg?)
> You need to decide if this should be printed even if -q is passed, should it
> be colorized, etc...
>
> -A

I would appreciate it if someone more familiar with portage could make
that decision and replace the print(e) with something better. Please
don't wait for me to familiarize myself with the code to fix this
rather annoying behavior.