Gentoo Archives: gentoo-portage-dev

From: Amber Schenck <ambersck@×××××××.com>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal
Date: Sat, 04 Dec 2021 18:25:38
Message-Id: PH0PR02MB733534D7B1879304306B481ACD6B9@PH0PR02MB7335.namprd02.prod.outlook.com
In Reply to: Re: [gentoo-portage-dev] [PATCH] portage.output: Replace darkblue colors with teal by Fabian Groffen
1 On 12/4/21 00:56, Fabian Groffen wrote:
2 > Why don't you change your color.map instead of changing the default for
3 > everyone?
4
5 As a more-or-less average user, the dark blue text has been bothersome
6 for quite some time, but never quite enough to figure out how to fix.
7 This change would be quite welcome.
8
9
10 -Amber
11
12 > Thanks,
13 > Fabian
14 >
15 > On 04-12-2021 05:48:49 +0100, Michał Górny wrote:
16 >> The "darkblue" color is often barely visible on dark terminals which
17 >> makes reading emerge output really hard (I basically have to copy-paste
18 >> it a lot in order to be able to read it at all). Replace it with teal
19 >> that does not seem to have any significant use in the output.
20 >>
21 >> Signed-off-by: Michał Górny <mgorny@g.o>
22 >> ---
23 >> lib/portage/output.py | 6 +++---
24 >> man/color.map.5 | 6 +++---
25 >> 2 files changed, 6 insertions(+), 6 deletions(-)
26 >>
27 >>
28 >> The before-after screenshot can be found on the PR:
29 >> https://github.com/gentoo/portage/pull/776
30 >>
31 >>
32 >> diff --git a/lib/portage/output.py b/lib/portage/output.py
33 >> index 42f487f8a..77375b012 100644
34 >> --- a/lib/portage/output.py
35 >> +++ b/lib/portage/output.py
36 >> @@ -157,7 +157,7 @@ _styles["UNMERGE_WARN"] = ("red",)
37 >> _styles["SECURITY_WARN"] = ("red",)
38 >> _styles["MERGE_LIST_PROGRESS"] = ("yellow",)
39 >> _styles["PKG_BLOCKER"] = ("red",)
40 >> -_styles["PKG_BLOCKER_SATISFIED"] = ("darkblue",)
41 >> +_styles["PKG_BLOCKER_SATISFIED"] = ("teal",)
42 >> _styles["PKG_MERGE"] = ("darkgreen",)
43 >> _styles["PKG_MERGE_SYSTEM"] = ("darkgreen",)
44 >> _styles["PKG_MERGE_WORLD"] = ("green",)
45 >> @@ -165,8 +165,8 @@ _styles["PKG_BINARY_MERGE"] = ("purple",)
46 >> _styles["PKG_BINARY_MERGE_SYSTEM"] = ("purple",)
47 >> _styles["PKG_BINARY_MERGE_WORLD"] = ("fuchsia",)
48 >> _styles["PKG_UNINSTALL"] = ("red",)
49 >> -_styles["PKG_NOMERGE"] = ("darkblue",)
50 >> -_styles["PKG_NOMERGE_SYSTEM"] = ("darkblue",)
51 >> +_styles["PKG_NOMERGE"] = ("teal",)
52 >> +_styles["PKG_NOMERGE_SYSTEM"] = ("teal",)
53 >> _styles["PKG_NOMERGE_WORLD"] = ("blue",)
54 >> _styles["PROMPT_CHOICE_DEFAULT"] = ("green",)
55 >> _styles["PROMPT_CHOICE_OTHER"] = ("red",)
56 >> diff --git a/man/color.map.5 b/man/color.map.5
57 >> index 288bf7fbd..92a1baa91 100644
58 >> --- a/man/color.map.5
59 >> +++ b/man/color.map.5
60 >> @@ -40,7 +40,7 @@ Defines color used for numbers indicating merge progress.
61 >> \fBPKG_BLOCKER\fR = \fI"red"\fR
62 >> Defines color used for unsatisfied blockers.
63 >> .TP
64 >> -\fBPKG_BLOCKER_SATISFIED\fR = \fI"darkblue"\fR
65 >> +\fBPKG_BLOCKER_SATISFIED\fR = \fI"teal"\fR
66 >> Defines color used for satisfied blockers.
67 >> .TP
68 >> \fBPKG_MERGE\fR = \fI"darkgreen"\fR
69 >> @@ -63,10 +63,10 @@ package.
70 >> Defines color used for world packages planned to be merged using a binary
71 >> package.
72 >> .TP
73 >> -\fBPKG_NOMERGE\fR = \fI"darkblue"\fR
74 >> +\fBPKG_NOMERGE\fR = \fI"teal"\fR
75 >> Defines color used for packages not planned to be merged.
76 >> .TP
77 >> -\fBPKG_NOMERGE_SYSTEM\fR = \fI"darkblue"\fR
78 >> +\fBPKG_NOMERGE_SYSTEM\fR = \fI"teal"\fR
79 >> Defines color used for system packages not planned to be merged.
80 >> .TP
81 >> \fBPKG_NOMERGE_WORLD\fR = \fI"blue"\fR
82 >> --
83 >> 2.34.1
84 >>
85 >>

Attachments

File name MIME type
OpenPGP_signature.asc application/pgp-signature

Replies