| 1 |
Jason Stubbs wrote: |
| 2 |
> On Saturday 29 October 2005 13:20, Jason Stubbs wrote: |
| 3 |
> |
| 4 |
>>I've adjusted the patch a bit to make all method signature changes into |
| 5 |
>>keyword arguments. I've also change the default tree to None and added a |
| 6 |
>>warning message to doebuild when None is passed and defaulting it to tree |
| 7 |
>>there. With the EAPI changes, passing a tree is really a requirement. If a |
| 8 |
>>tree isn't passed, it'd be better to alert people to that rather than |
| 9 |
>>trying to backtrack to it as the cause of the bugs that will inevitably pop |
| 10 |
>>up. |
| 11 |
> |
| 12 |
> |
| 13 |
> Many usages of doebuild in emerge - one of which wasn't meant to go to |
| 14 |
> "porttree". The warning has helped already! ;) |
| 15 |
> |
| 16 |
> Cleaned up those instances and also fixed a typo (of mine) in |
| 17 |
> portage.unmerge(). |
| 18 |
> |
| 19 |
|
| 20 |
I'm using your new patch an it looks good. Nice idea to place that warning in there. I did a recursive grep and found a couple doebuild calls that will generate a warning (see patch). It looks like you're about ready to package up an _rc7 that hopefully will become stable soon. :) |
| 21 |
|
| 22 |
Zac |
Archives