Re: [gentoo-portage-dev] [PATCH] Default MAKEOPTS to -j(ncpus+1) when unset

[Michał Górny]

Dnia 2015-01-17, o godz. 20:48:11
Zac Medico <zmedico@g.o> napisał(a):

> On 01/17/2015 08:22 PM, Zac Medico wrote:
> > On 01/17/2015 02:45 AM, Michał Górny wrote:
> >> Default MAKEOPTS job number to (number of CPUs + 1) when it is not
> >> provided in the ebuild environment.
> >>
> >> Suggested-By: Daniel Robbins <drobbins@××××××.org>
> >> ---
> >>  pym/portage/package/ebuild/doebuild.py |  8 +++++++-
> >>  pym/portage/util/cpuinfo.py            | 19 +++++++++++++++++++
> >>  2 files changed, 26 insertions(+), 1 deletion(-)
> >>  create mode 100644 pym/portage/util/cpuinfo.py
> >
> > LGTM.
> >
>
> Actually, Arfrever tells me that the multiprocessing module is not
> available if python is built without threading support. So, we need to
> handle the ImportError and either do nothing or parse /proc/cpuinfo or
> something like that.

I don't think there's a point in having more complexity for a use case
that doesn't really get used. Except maybe for the few 'USE=-*' people
who aren't cautious enough but they're going to be hit by some failure
sooner or later.

I'm going to remove the flag on the Python end after verifying
the USE-deps.

-- 
Best regards,
Michał Górny