Gentoo Archives: gentoo-portage-dev

From: "M. J. Everitt" <m.j.everitt@×××.org>
To: gentoo-portage-dev@l.g.o, "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH 0/4] Rename PORT_LOGDIR{,_CLEAN} variables to PORTAGE_LOGDIR{,_CLEAN} Bug 668538
Date: Mon, 17 Dec 2018 05:13:10
In Reply to: Re: [gentoo-portage-dev] [PATCH 0/4] Rename PORT_LOGDIR{,_CLEAN} variables to PORTAGE_LOGDIR{,_CLEAN} Bug 668538 by "Michał Górny"
1 On 15/12/18 08:55, Michał Górny wrote:
2 > On Sat, 2018-12-15 at 02:25 +0000, M. J. Everitt wrote:
3 >> This patchset aims to fix potential ambiguity and confusion between older PORT_LOG* variables,
4 >> and more recent PORTAGE_* variables - often leading to mysteriously lacking logging due to
5 >> incorrect variable names. Documented in Bug 668538; with thanks to Zac for diagnosis, and
6 >> solution assistance!
7 >>
8 > Does 'often' actually affect more than one person? Do you have any
9 > evidence to support this?
10 >
11 > Given that a lot of Portage variables don't have any prefix or sane
12 > names, I dare say this one doesn't especially stand out.
13 >
14 Just a thought, but how about you apply your skill and wisdom to reviewing
15 the patches, instead of wasting it on writing snide replies?
16 Quite radical I know, but whadda ya think?!
18 As it happens, I was going for consistency here, as that often reflects
19 code quality, and you being a keen QA member, I'da thought perhaps you
20 might have spotted this!
22 Not only this, but as noted, unless you know the man pages for portage and
23 make.conf in order to recite them in your sleep, they are confusing for
24 users, as they do not necessarily follow an obvious pattern, and it wasn't
25 until I was attempting to debug something that I noticed that despite
26 believing I had the correct settings in my make.conf (set over a period of
27 YEARS) they were in fact completely useless, and it wasn't until I had to
28 spend time with somebody debugging WTF was happening, that this particular
29 issue even became apparent...


File name MIME type
signature.asc application/pgp-signature