| 1 |
On 12/07/2014 01:07 AM, Michał Górny wrote: |
| 2 |
> Dnia 2014-12-07, o godz. 10:01:23 |
| 3 |
> Michał Górny <mgorny@g.o> napisał(a): |
| 4 |
> |
| 5 |
>> + if uid is not None |
| 6 |
> |
| 7 |
> Missing ':' here, I won't resend the patch for it :P. |
| 8 |
> |
| 9 |
>> + spawn_kwargs["uid"] = uid |
| 10 |
>> + self.usersync_uid = uid |
| 11 |
>> + if gid is not None: |
| 12 |
>> + spawn_kwargs["gid"] = gid |
| 13 |
>> + spawn_kwargs["groups"] = [gid] |
| 14 |
>> + if home is not None: |
| 15 |
>> + spawn_kwargs["env"]["HOME"] = home |
| 16 |
>> + elif ('usersync' in self.settings.features and |
| 17 |
>> portage.data.secpass >= 2 and |
| 18 |
>> (st.st_uid != os.getuid() and st.st_mode & 0o700 or |
| 19 |
>> st.st_gid != os.getgid() and st.st_mode & 0o070)): |
| 20 |
> |
| 21 |
> |
| 22 |
> |
| 23 |
|
| 24 |
LGTM. |
| 25 |
-- |
| 26 |
Thanks, |
| 27 |
Zac |
Archives