Re: [gentoo-portage-dev] [PATCH 2/2] EAPI 6: Enforce LC_COLLATE=C in ebuild environment

[Zac Medico]

On 11/14/2015 02:56 PM, Michał Górny wrote:
> +
> +
> +def split_LC_ALL(env):
> +	"""
> +	Replace LC_ALL with split-up LC_* variables if it is defined.
> +	Works on the passed environment (or settings instance).
> +	"""
> +	lc_all = env.get("LC_ALL")
> +	if lc_all is not None:
> +		for c in locale_categories:
> +			env[c] = lc_all
> +		del env["LC_ALL"]
>

Due to the implementation details of the config.__del__ method, the del
call will have an irreversible effect on the config instance. That's
bad, because the same config instance is reused for other EAPIs. I think
the simplest solution will be to call this function on the "mydict"
inside the config.environ() method, since changes to "mydict" only
affect the result that is returned from that method.
-- 
Thanks,
Zac