Gentoo Archives: gentoo-portage-dev

From: Sergei Trofimovich <slyfox@g.o>
To: mgorny@g.o
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: Finally deprecate base.eclass
Date: Thu, 22 Oct 2015 21:03:20
Message-Id: 20151022220305.70d1ba89@sf
In Reply to: [gentoo-portage-dev] [PATCH] repoman: Finally deprecate base.eclass by "Michał Górny"
1 On Sun, 11 Oct 2015 09:23:20 +0200
2 Michał Górny <mgorny@g.o> wrote:
3
4 > Contributors are repeatedly adding base.eclass uses, so we should
5 > finally make the deprecation formal, even at the cost of adding warnings
6 > for some frequently used eclasses.
7 >
8 > Signed-off-by: Michał Górny <mgorny@g.o>
9 > ---
10 > pym/repoman/checks/ebuilds/checks.py | 1 +
11 > 1 file changed, 1 insertion(+)
12 >
13 > diff --git a/pym/repoman/checks/ebuilds/checks.py b/pym/repoman/checks/ebuilds/checks.py
14 > index ae6d96e..a00d518 100644
15 > --- a/pym/repoman/checks/ebuilds/checks.py
16 > +++ b/pym/repoman/checks/ebuilds/checks.py
17 > @@ -409,6 +409,7 @@ class InheritDeprecated(LineCheck):
18 >
19 > # deprecated eclass : new eclass (False if no new eclass)
20 > deprecated_eclasses = {
21 > + "base": False,
22 > "bash-completion": "bash-completion-r1",
23 > "boost-utils": False,
24 > "distutils": "distutils-r1",
25 > --
26 > 2.6.1
27
28 I would also suggest:
29
30 - adding a @DEPRECATED documentation stanza
31 right into base.eclass with a migration strategy link
32 - and a ewarn/eqawarn call to flag all offenders and prevent
33 new ebuilds to creep dependency back
34
35 --
36
37 Sergei

Attachments

File name MIME type
signature.asc application/pgp-signature