Gentoo Archives: gentoo-portage-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.
Date: Fri, 13 Dec 2019 19:24:42
Message-Id: eb4ab8a7-3e46-15a2-b4d4-a45c07aa5397@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch. by Fabian Groffen
1 On 12/13/19 9:28 AM, Fabian Groffen wrote:
2 >
3 > We are providing those patches, maybe. In reality very often the
4 > patches originate from somewhere else though. And you don't want to
5 > have to respin all of those just because. At least that's what I feel.
6 >
7
8 Just because... the context changed? A new "!" in a line of context can
9 be the difference between letting someone log in with the right password
10 and letting them log in with the wrong password. You should at least
11 have to stop and verify that the patch does what you think it does when
12 it "gains" fuzz. And at that point, git diff will give you a clean
13 version of it.

Replies

Subject Author
Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch. Fabian Groffen <grobian@g.o>