Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] VdbMetadataDelta.applyDelta: remove replaced versions (bug 547532)
Date: Thu, 07 May 2015 08:06:59
Message-Id: 554B1D17.60209@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] VdbMetadataDelta.applyDelta: remove replaced versions (bug 547532) by Zac Medico
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 24/04/15 18:32, Zac Medico wrote:
5 > - installed_package = installed_package[-1]
6 > + try:
7 > + self._vardb.match_unordered
8 > + except AttributeError:
9 > + installed_package = installed_package[-1]
10 > + else:
11 > + installed_package = portage.best(installed_package)
12 > +
13 This probably makes sense, but I don't understand how this helps to
14 alleviate the problem. Would you mind explaining it?
15
16 The rest of the patch looks OK, even if I dislike the strong imperative
17 nature of the replaced versions removal.
18 - --
19 Alexander
20 bernalex@g.o
21 https://secure.plaimi.net/~alexander
22 -----BEGIN PGP SIGNATURE-----
23 Version: GnuPG v2
24
25 iQIcBAEBCgAGBQJVSx0VAAoJENQqWdRUGk8B3/AQAJnM8XhSS3ps1mDIIZZ656bF
26 cNlnkzzBnX7OkyhjFrSISSkov23I81+yb/3nsiR7/iT4N8TdzxvkX2nPOKWysVxE
27 K8FsF56KQny6vFEqtztRO715Nm92/V62zP0L1jDaG7snml4SFnc/+SWZRXimJsUr
28 wlgYXDvpaEpc6dh1U+nA3kbqcyiic4EYIWrd+LXY9WV0wPMJrjXNHw30gYEwoPpM
29 JonoJEjEyen8Y7KEQoIbBrMht/S4dCX+J2mnOgne4fod4oFWeNfwdgZ1QZ6HrcyA
30 WDR2akmX/4azcOIAXkm83GXY4VaCuYgKWqCBAuXcxALoEQBP9diCn0XcVuoTSAwU
31 z5YvDvuKvgx3uC1kLWLEUU7bwfbJ7MKHDKjal3rLaR9rYEt9jt6e4na/gpl8wiIN
32 ECILO64baHEnWz8mbKpq6E9e9Wte8mE87ACRpg/38P31EinTKCt1y/F9/eS/frjF
33 C2OwUoOyfsZyPlu4fLdF7bZbC0HvPYt4e+obrA06bqaY2ubSyS1qA1Xz41TBgELI
34 IeHcq+t+i5lXSpJTH0mMjtWyj7GhuB5ZxBIXAoly/p07y37FW4hz5sGGUryfEOVr
35 +HPV3iUAjUeCfaE9JzzJyWIJYzgKyYCBbi9V1eV4VpEjWppBkxzJgjNPF1v4xyh/
36 6nDTC0txOZMzWq6avA4Q
37 =WW8m
38 -----END PGP SIGNATURE-----

Replies