Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] bin/ebuild: fix --color=n for bug #531690
Date: Sun, 07 Dec 2014 05:53:01
Message-Id: 20141206215233.6c162ee0.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] bin/ebuild: fix --color=n for bug #531690 by Zac Medico
1 On Sat, 6 Dec 2014 11:24:47 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > When the NOCOLOR variable is overridden in portage.settings, it's
5 > necessary to call the config.backup_changes method in order for the
6 > change to persist through config.reset calls.
7 >
8 > X-Gentoo-Bug: 531690
9 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=531690
10 > ---
11 > bin/ebuild | 1 +
12 > 1 file changed, 1 insertion(+)
13 >
14 > diff --git a/bin/ebuild b/bin/ebuild
15 > index a62aa20..ad52ed5 100755
16 > --- a/bin/ebuild
17 > +++ b/bin/ebuild
18 > @@ -110,6 +110,7 @@ if not opts.color == 'y' and \
19 > portage.output.nocolor()
20 > portage.settings.unlock()
21 > portage.settings['NOCOLOR'] = 'true'
22 > + portage.settings.backup_changes('NOCOLOR')
23 > portage.settings.lock()
24 >
25 > ebuild = pargs.pop(0)
26
27
28 that looks like a "DOH!" fix patch ;)
29
30 merge please
31
32 --
33 Brian Dolbec <dolsen>