| 1 |
On Wed, Nov 11, 2015 at 10:09:42PM -0800, Zac Medico wrote: |
| 2 |
> On 11/11/2015 02:30 PM, robbat2@g.o wrote: |
| 3 |
> > From: "Robin H. Johnson" <robbat2@g.o> |
| 4 |
> > |
| 5 |
> > If GIT_DIR is used, and .git is outside the root of the checkout, then |
| 6 |
> > --work-tree=... needs to be specified, otherwise any Git command that |
| 7 |
> > relies on relative directories to the root will be wrong. |
| 8 |
> > |
| 9 |
> > Signed-off-by: Robin H. Johnson <robbat2@g.o> |
| 10 |
> > --- |
| 11 |
> > bin/egencache | 31 +++++++++++++++++++++++-------- |
| 12 |
> > 1 file changed, 23 insertions(+), 8 deletions(-) |
| 13 |
> Looks good. |
| 14 |
Thanks, merged. |
| 15 |
|
| 16 |
> > + '--relative=%s' % (cp, ), |
| 17 |
> This addition could be mentioned in the commit message. |
| 18 |
Added to the commit message. |
| 19 |
|
| 20 |
> > def run(self): |
| 21 |
> > - repo_path = self._portdb.porttrees[0] |
| 22 |
> > - os.chdir(repo_path) |
| 23 |
> > + os.chdir(self._repo_path) |
| 24 |
> The chdir calls make me nervous, since we should be careful to ensure |
| 25 |
> that they are timed correctly when we introduce parallelization. I'd |
| 26 |
> love to add a cwd argument for the grab method to pass into Popen, in |
| 27 |
> order to eliminate all of the chdir calls. |
| 28 |
Agreed; I like your later patch for it. |
| 29 |
|
| 30 |
-- |
| 31 |
Robin Hugh Johnson |
| 32 |
Gentoo Linux: Developer, Infrastructure Lead, Foundation Trustee |
| 33 |
E-Mail : robbat2@g.o |
| 34 |
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 |
Archives