| 1 |
On Tue, Sep 28, 2021 at 2:25 AM Michał Górny <mgorny@g.o> wrote: |
| 2 |
> |
| 3 |
> On Mon, 2021-09-27 at 21:09 -0400, Mike Gilbert wrote: |
| 4 |
> > On Mon, Sep 27, 2021 at 1:20 PM Michał Górny <mgorny@g.o> wrote: |
| 5 |
> > > + eqawarn |
| 6 |
> > > + eqawarn "It is impossible to reliably guarantee that the extended attributes" |
| 7 |
> > > + eqawarn "will be reliably preserved while merging. Please ensure that any" |
| 8 |
> > > + eqawarn "extended metadata necessary is applied in pkg_postinst() phase," |
| 9 |
> > > + eqawarn "and that the implementation includes a fallback if necessary." |
| 10 |
> > |
| 11 |
> > This message suggests that applying xattrs in pkg_postinst is |
| 12 |
> > acceptable. However, your patch offers no way to disable the QA |
| 13 |
> > warning for ebuilds that do so. |
| 14 |
> |
| 15 |
> We'll cross that bridge when we get there. Ideally, we wouldn't need to |
| 16 |
> silence the check because no packages would do that. If they do, then |
| 17 |
> we'll probably want to work on an eclass like fcaps.eclas. |
| 18 |
|
| 19 |
We need a way to silence this thing when false positives pop up and/or |
| 20 |
ebuilds are adjusted. That needs to be there from day 1, not when we |
| 21 |
cross some bridge later. |
| 22 |
|
| 23 |
An immediate example: packages that call pax-mark in src_compile |
| 24 |
because the need to disable MPROTECT on binary that is called a |
| 25 |
compile time will end up with extended attributes in ${D} due to |
| 26 |
install-xattr. We can adjust them to also call pax-mark in |
| 27 |
pkg_postinst, but that won't magically make them go away in ${D}. |
Archives