1 |
In reply, you will find three repoman patches; PATCH 1 is a bit more complex |
2 |
which I will detail here, the other two patches should be fairly trivial. |
3 |
|
4 |
In the first patch I need to use the @system set, as I only want to check |
5 |
DEPEND for packages not in the @system set; thus here is kept in mind that |
6 |
the @system set could possible change, in which case the check continues to |
7 |
work. After checking up with Arfrever, a first version that I came up with is |
8 |
|
9 |
> +from portage._sets.profiles import PackagesSystemSet |
10 |
> +system_set_atoms = PackagesSystemSet(portage.settings.profiles).getAtoms() |
11 |
|
12 |
but I am not sure if this is appropriate when used in other repositories. |
13 |
Arfrever warned me about this but I think I do not fully understand that. |
14 |
|
15 |
Both archive_formats* variables are based on the PMS specifications. |
16 |
|
17 |
The rest of the code has comments and should be trivial to understand. |
18 |
|
19 |
For the check name we came up with "unpack.DEPEND.missing"; most of the |
20 |
checks are two words, so, I don't know if three words is permitted. At least |
21 |
repoman runs without complaining or bailing out because of this. |
22 |
|
23 |
There's still a TODO left in the code that leaves me in doubt on how to |
24 |
properly ask the keywords to Portage; seems that I still need to learn to |
25 |
find my way through the documentation, but I guess after getting pointed to |
26 |
it a few times it will become easier. |
27 |
|
28 |
These are my first patches to the Repoman code, all three patches introduce a |
29 |
new warning / error, therefore it might be possible that I missed something. |
30 |
Grepping on an existing warning I saw the man page needs to be updated; since |
31 |
I never did that before, feel free to check if the syntax of that is right. |
32 |
|
33 |
Thank you for taking your time to review these. |
34 |
|
35 |
-- |
36 |
bin/repoman | 63 ++++++++++++++++++++++++++++++++++++++++++++++++ |
37 |
+++++++++++++++ |
38 |
man/repoman.1 | 10 ++++++++++ |
39 |
pym/repoman/checks.py | 10 ++++++++++ |
40 |
3 files changed, 83 insertions(+) |
41 |
|
42 |
[PATCH 1/3] Have repoman check if the packages to unpack rare archive |
43 |
formats from SRC_URI are present in DEPEND (bug #205909). |
44 |
|
45 |
[PATCH 2/3] Have repoman check that a package directory contains at least |
46 |
one ebuild (bug #245305). |
47 |
|
48 |
[PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084). |
49 |
|
50 |
-- |
51 |
With kind regards, |
52 |
|
53 |
Tom Wijsman (TomWij) |
54 |
Gentoo Developer |
55 |
|
56 |
E-mail address : TomWij@g.o |
57 |
GPG Public Key : 6D34E57D |
58 |
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D |