1 |
On 12/13/2015 04:58 AM, Michał Górny wrote: |
2 |
>>> 39d81c5 portage.package.ebuild.config.config.__getitem__(): Partially drop backward compatibility for nonexistent keys. |
3 |
>>> |
4 |
>>> Maybe keep it but needs someone smarter than me to review. |
5 |
>> |
6 |
>> Looks good, except the last hunk seems redundant because "for x in self" |
7 |
>> should only yield valid keys: |
8 |
>> |
9 |
>> @@ -2697,7 +2714,9 @@ class config(object): |
10 |
>> for x in self: |
11 |
>> if x in environ_filter: |
12 |
>> continue |
13 |
>> - myvalue = self[x] |
14 |
>> + myvalue = self.get(x) |
15 |
>> + if myvalue is None: |
16 |
>> + continue |
17 |
> |
18 |
> Could you fix it then, please? |
19 |
|
20 |
Fixed: |
21 |
|
22 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=6ba56ad7be84b18dcbf15e8c6b283f5a9a559123 |
23 |
-- |
24 |
Thanks, |
25 |
Zac |