Gentoo Archives: gentoo-portage-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH 1/3] runtests: add a "supported" shortcut
Date: Sun, 05 Jan 2014 15:50:40
Message-Id: 1388937034-22930-1-git-send-email-vapier@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] document release process by Mike Frysinger
1 This keeps the list of supported versions in one place so people can do:
2 ./runtests.sh --python-versions=supported
3
4 No need to hardcode the list of python versions in multiple places.
5 ---
6 DEVELOPING | 6 +++---
7 runtests.sh | 5 +++++
8 2 files changed, 8 insertions(+), 3 deletions(-)
9
10 diff --git a/DEVELOPING b/DEVELOPING
11 index 5dfd9b7..7aac81b 100644
12 --- a/DEVELOPING
13 +++ b/DEVELOPING
14 @@ -171,9 +171,9 @@ Then create the tarball:
15 ./mkrelease.sh --changelog-rev v2.2.7 --tag 2.2.8
16
17 Unpack the tarball and run tests:
18 - ./runtests.sh
19 -Make sure you have all supported python versions installed:
20 - 2.6 2.7 3.2 3.3
21 + ./runtests.sh --python-versions=supported
22 +Make sure you have all supported python versions installed first
23 +(see PYTHON_SUPPORTED_VERSIONS in runtests.sh).
24
25 Version bump the ebuild and verify it can re-install itself:
26 emerge portage
27 diff --git a/runtests.sh b/runtests.sh
28 index 010a7bf..3006be5 100755
29 --- a/runtests.sh
30 +++ b/runtests.sh
31 @@ -2,6 +2,8 @@
32 # Copyright 2010-2012 Gentoo Foundation
33 # Distributed under the terms of the GNU General Public License v2
34
35 +# These are the versions we care about. The rest are just "nice to have".
36 +PYTHON_SUPPORTED_VERSIONS="2.6 2.7 3.2 3.3"
37 PYTHON_VERSIONS="2.6 2.7 2.7-pypy-1.8 2.7-pypy-1.9 2.7-pypy-2.0 3.1 3.2 3.3 3.4"
38
39 # has to be run from portage root dir
40 @@ -44,6 +46,9 @@ while [ $# -gt 0 ] ; do
41 esac
42 shift
43 done
44 +if [[ ${PYTHON_VERSIONS} == "supported" ]] ; then
45 + PYTHON_VERSIONS=${PYTHON_SUPPORTED_VERSIONS}
46 +fi
47
48 set -- "${unused_args[@]}"
49
50 --
51 1.8.4.3

Replies