| 1 |
On 01/17/2015 09:35 AM, Michał Górny wrote: |
| 2 |
> Fix the svn sync module since it doesn't work at all right now. More |
| 3 |
> specifically: |
| 4 |
> |
| 5 |
> 1. add exists() method that uses 'svn info' to determine whether |
| 6 |
> the repository was checked out already. |
| 7 |
> |
| 8 |
> 2. Fix the initial clone to use valid svn commands. Do not remove |
| 9 |
> the just-created directory to avoid permission issues, just run checkout |
| 10 |
> on top of it. |
| 11 |
|
| 12 |
In case the reader is wondering, we could clarify that |
| 13 |
SyncManager.pre_sync creates the directory and sets the permissions. |
| 14 |
|
| 15 |
> 3. Fix the sync method to run update unconditionally to whether the URI |
| 16 |
> starts with svn:// or not. In fact, remove the whole check since it |
| 17 |
> doesn't serve any purpose. |
| 18 |
> --- |
| 19 |
> pym/portage/sync/modules/svn/svn.py | 54 ++++++++++++++++++++----------------- |
| 20 |
> 1 file changed, 29 insertions(+), 25 deletions(-) |
| 21 |
|
| 22 |
LGTM. |
| 23 |
-- |
| 24 |
Thanks, |
| 25 |
Zac |
Archives